-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add RO-Crate OpenAPI specs #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start @Rahuljagwani. Don't be intimidated by all the comments, just want to make sure everything is very clean and consistent ;-)
As I said, yesterday, @Rahuljagwani - please remove everything except the specs from this PR, open other PRs (ci, docs, build, chore) for the other files/issues and then (re-)request reviews on all PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there :) Still there may be some small things in the operations, but I don't think there will be more than one additional reviewing round here. Next time I will also review the models, but I guess for now there's already enough to update.
Closing in favor of #29 (all comments to the OpenAPI specs have been resolved in that PR) |
Work done
setup.py
to package the service.